exttex
/
just_audio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Moved _player._broadcastSequence() call under null check (#204)

This commit is contained in:
Sergio Tikhonov 2020-10-11 05:26:18 +03:00 committed by GitHub
parent 9dbde5bda8
commit f0aa6b6fe0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
just_audio/lib/just_audio.dart
View File

@ -1324,8 +1324,8 @@ class ConcatenatingAudioSource extends AudioSource {
Future<void> add(AudioSource audioSource) async { Future<void> add(AudioSource audioSource) async {
final index = children.length; final index = children.length;
children.add(audioSource); children.add(audioSource);
_player._broadcastSequence();
if (_player != null) { if (_player != null) {
_player._broadcastSequence();
await (await _player._platform).concatenatingInsertAll( await (await _player._platform).concatenatingInsertAll(
ConcatenatingInsertAllRequest( ConcatenatingInsertAllRequest(
id: _id, index: index, children: [audioSource._toMessage()])); id: _id, index: index, children: [audioSource._toMessage()]));
@ -1335,8 +1335,8 @@ class ConcatenatingAudioSource extends AudioSource {
/// (Untested) Inserts an [AudioSource] at [index]. /// (Untested) Inserts an [AudioSource] at [index].
Future<void> insert(int index, AudioSource audioSource) async { Future<void> insert(int index, AudioSource audioSource) async {
children.insert(index, audioSource); children.insert(index, audioSource);
_player._broadcastSequence();
if (_player != null) { if (_player != null) {
_player._broadcastSequence();
await (await _player._platform).concatenatingInsertAll( await (await _player._platform).concatenatingInsertAll(
ConcatenatingInsertAllRequest( ConcatenatingInsertAllRequest(
id: _id, index: index, children: [audioSource._toMessage()])); id: _id, index: index, children: [audioSource._toMessage()]));
@ -1347,8 +1347,8 @@ class ConcatenatingAudioSource extends AudioSource {
Future<void> addAll(List<AudioSource> children) async { Future<void> addAll(List<AudioSource> children) async {
int index = this.children.length; int index = this.children.length;
this.children.addAll(children); this.children.addAll(children);
_player._broadcastSequence();
if (_player != null) { if (_player != null) {
_player._broadcastSequence();
await (await _player._platform).concatenatingInsertAll( await (await _player._platform).concatenatingInsertAll(
ConcatenatingInsertAllRequest( ConcatenatingInsertAllRequest(
id: _id, id: _id,
@ -1360,8 +1360,8 @@ class ConcatenatingAudioSource extends AudioSource {
/// (Untested) Insert multiple [AudioSource]s at [index]. /// (Untested) Insert multiple [AudioSource]s at [index].
Future<void> insertAll(int index, List<AudioSource> children) async { Future<void> insertAll(int index, List<AudioSource> children) async {
this.children.insertAll(index, children); this.children.insertAll(index, children);
_player._broadcastSequence();
if (_player != null) { if (_player != null) {
_player._broadcastSequence();
await (await _player._platform).concatenatingInsertAll( await (await _player._platform).concatenatingInsertAll(
ConcatenatingInsertAllRequest( ConcatenatingInsertAllRequest(
id: _id, id: _id,
@ -1374,8 +1374,8 @@ class ConcatenatingAudioSource extends AudioSource {
/// [ConcatenatingAudioSource] has already been loaded. /// [ConcatenatingAudioSource] has already been loaded.
Future<void> removeAt(int index) async { Future<void> removeAt(int index) async {
children.removeAt(index); children.removeAt(index);
_player._broadcastSequence();
if (_player != null) { if (_player != null) {
_player._broadcastSequence();
await (await _player._platform).concatenatingRemoveRange( await (await _player._platform).concatenatingRemoveRange(
ConcatenatingRemoveRangeRequest( ConcatenatingRemoveRangeRequest(
id: _id, startIndex: index, endIndex: index + 1)); id: _id, startIndex: index, endIndex: index + 1));
@ -1386,8 +1386,8 @@ class ConcatenatingAudioSource extends AudioSource {
/// to [end] exclusive. /// to [end] exclusive.
Future<void> removeRange(int start, int end) async { Future<void> removeRange(int start, int end) async {
children.removeRange(start, end); children.removeRange(start, end);
_player._broadcastSequence();
if (_player != null) { if (_player != null) {
_player._broadcastSequence();
await (await _player._platform).concatenatingRemoveRange( await (await _player._platform).concatenatingRemoveRange(
ConcatenatingRemoveRangeRequest( ConcatenatingRemoveRangeRequest(
id: _id, startIndex: start, endIndex: end)); id: _id, startIndex: start, endIndex: end));
@ -1397,8 +1397,8 @@ class ConcatenatingAudioSource extends AudioSource {
/// (Untested) Moves an [AudioSource] from [currentIndex] to [newIndex]. /// (Untested) Moves an [AudioSource] from [currentIndex] to [newIndex].
Future<void> move(int currentIndex, int newIndex) async { Future<void> move(int currentIndex, int newIndex) async {
children.insert(newIndex, children.removeAt(currentIndex)); children.insert(newIndex, children.removeAt(currentIndex));
_player._broadcastSequence();
if (_player != null) { if (_player != null) {
_player._broadcastSequence();
await (await _player._platform).concatenatingMove( await (await _player._platform).concatenatingMove(
ConcatenatingMoveRequest( ConcatenatingMoveRequest(
id: _id, currentIndex: currentIndex, newIndex: newIndex)); id: _id, currentIndex: currentIndex, newIndex: newIndex));
@ -1408,8 +1408,8 @@ class ConcatenatingAudioSource extends AudioSource {
/// (Untested) Removes all [AudioSources]. /// (Untested) Removes all [AudioSources].
Future<void> clear() async { Future<void> clear() async {
children.clear(); children.clear();
_player._broadcastSequence();
if (_player != null) { if (_player != null) {
_player._broadcastSequence();
await (await _player._platform).concatenatingRemoveRange( await (await _player._platform).concatenatingRemoveRange(
ConcatenatingRemoveRangeRequest( ConcatenatingRemoveRangeRequest(
id: _id, startIndex: 0, endIndex: children.length)); id: _id, startIndex: 0, endIndex: children.length));